HMGforum.com

Posted: **Mon May 04, 2009 2:02 am**

Harbour MiniGUI 2.9.0 Changelog:

English:

- Fixed: Grid (CellNavigation). OnChange event not fired when selection is automatically changed after accepting cell edit with [Enter].

Regards,

Roberto.

Posted: **Mon May 04, 2009 4:20 am**

Thanks a lot Roberto.

Posted: **Mon May 04, 2009 8:49 am**

Thanks a lot Le Roy

Best Regards

--

Esgici

Posted: **Mon May 04, 2009 12:11 pm**

Thank´s Master Roberto,
for this nice and great work.

Regards,

Posted: **Tue May 05, 2009 2:13 pm**

Roberto Lopez wrote:Harbour MiniGUI 2.9.0 Changelog:

Hi Roberto,

There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:

Code: Select all

			* Grid Processing .....................................

			if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID") 

				IF _HMG_SYSDATA [32] [i] == .T.                // first checking for CellNavigation flag
	
       					* Grid Key Handling .........................

					If GetNotifyCode ( lParam ) = LVN_KEYDOWN

						IF _HMG_SYSDATA [32] [i] == .T.          // check again??

							Do Case
...

May be to fix an aboved issue in this build

Posted: **Tue May 05, 2009 2:40 pm**

gfilatov wrote:
Roberto Lopez wrote:Harbour MiniGUI 2.9.0 Changelog:

Hi Roberto,

There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:
Code: Select all
			* Grid Processing .....................................

			if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID") 

				IF _HMG_SYSDATA [32] [i] == .T.                // first checking for CellNavigation flag
	
       					* Grid Key Handling .........................

					If GetNotifyCode ( lParam ) = LVN_KEYDOWN

						IF _HMG_SYSDATA [32] [i] == .T.          // check again??

							Do Case
...
May be to fix an aboved issue in this build

CellNavigation has been a very complicated and difficult to debug feature.

It is possible that the code could be optimized, but until now, I've focused on bugs.

I'll take a look at it ASAP.

Thanks for reporting.

Regards,

Roberto.

Posted: **Tue May 05, 2009 2:54 pm**

Roberto Lopez wrote:CellNavigation has been a very complicated and difficult to debug feature.

It is possible that the code could be optimized, but until now, I've focused on bugs.

I'll take a look at it ASAP.

Thanks for reporting.

Roberto,

Thanks for your attention, maestro

I'm glad to help for code's optimization.

Posted: **Tue May 05, 2009 6:18 pm**

gfilatov wrote: There is a double checking for CellNavigation flag in the h_windows.prg.
Please take a look for the following code:

You are right. It was a completely nonsense double check

I've removed the extra 'if'.

Thanks for reporting.

Regards,

Roberto.

Posted: **Fri May 08, 2009 5:49 pm**

Talking about code optimization, the lines:

Code: Select all

if (_HMG_SYSDATA [1] [i] = "GRID") .Or. (_HMG_SYSDATA [1] [i] = "MULTIGRID")

            IF _HMG_SYSDATA [32] [i] == .T.

could be rewritten:

Code: Select all

if (_HMG_SYSDATA [1] [i] $ "MULTIGRID")

            IF (_HMG_SYSDATA [32] [i])

According to a quick test that i have done, the second "optimized" version is more than twice faster compared to the first.

P.S. Of course the above "optimization" it is proposed just for "educational / academical" reasons and in no way should be taken as correction, because we all know that the "real life coding" has its own rules, priorities and necessities..

regards,

---
Pete

HMGforum.com

HMG 2.9.0 (Forum test)

HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)

Re: HMG 2.9.0 (Forum test)