Welcome to the Project Developers' Table

Moderator: Rathinagiri

mrduck
Posts: 497
Joined: Fri Sep 10, 2010 5:22 pm

Re: Welcome to the Project Developers' Table

Post by mrduck »

Roberto, I sent a message some days ago with a url to a commit description. There you can see all the changes that need to be done in hmg code... the old :connect was replacing some strings to others, but NOT in this case.
itemSelectionChanged() is ok, but QWidget should become QWidget *, QLWItem -> QListWidgetItem...

In harbour developer list I also proposed a patch to Pritpal to throw more descriptive error messages, I will resume the message later today and force a commit... it will report the invalid signal name
User avatar
Roberto Lopez
HMG Founder
Posts: 4023
Joined: Wed Jul 30, 2008 6:43 pm

Re: Welcome to the Project Developers' Table

Post by Roberto Lopez »

mrduck wrote:Roberto, I sent a message some days ago with a url to a commit description. There you can see all the changes that need to be done in hmg code... the old :connect was replacing some strings to others, but NOT in this case.
itemSelectionChanged() is ok, but QWidget should become QWidget *, QLWItem -> QListWidgetItem...

In harbour developer list I also proposed a patch to Pritpal to throw more descriptive error messages, I will resume the message later today and force a commit... it will report the invalid signal name
Ok.

I remember your message.

I'll create new binaries soon and ask you for help about the changes.

Thanks.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
mlacecilia
Posts: 22
Joined: Fri Oct 08, 2010 2:44 pm

Re: Welcome to the Project Developers' Table

Post by mlacecilia »

Hi Roberto,
i'm working with 15699 and above.
The offending line 288 is:

::oQTObject:connect( "itemDoubleClicked(QLWItem)" , ::bOnDblClick )

The changed syntax is in:

2010-10-23 16:44 UTC+0200 Viktor Szakats (harbour.01 syenar.hu)
* contrib/hbqt/qtcore/hbqt_hbqslots.cpp
! Deleted hack to centrally manipulate non-standard slot
names used in app level code:
"QWidget" -> "QWidget *"
"QPrinter" -> "QPrinter *"
"QLWItem" -> "QListWidgetItem *"
"QTWItem" -> "QTreeWidgetItem *"
"QTblWItem" -> "QTableWidgetItem *"
"QMdiSubWindow" -> "QMdiSubWindow *"

and later:

2010-10-23 11:02 UTC-0800 Pritpal Bedi (bedipritpal@hotmail.com)
! Changed: :connect( "QClass *", ... ) => :connect( "QClass*", ... )
This way we are uniform with signal notation also confirm to Qt protocol.

I changed all the occurences in hmg sources of this changed slots, but now i obtain a RTE.
Best regards.
Maurizio
User avatar
Roberto Lopez
HMG Founder
Posts: 4023
Joined: Wed Jul 30, 2008 6:43 pm

Re: Welcome to the Project Developers' Table

Post by Roberto Lopez »

2010-10-27 17:37:00 UTC-0300 Roberto Lopez (<mail.box.hmg@gmail.com>)
* hmgide/ide.prg
* Focus rect in form editor implemented.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
mrduck
Posts: 497
Joined: Fri Sep 10, 2010 5:22 pm

Re: Welcome to the Project Developers' Table

Post by mrduck »

mlacecilia wrote: Error BASE/1100 Argument error: CONNECT

Called from __HBQT_SLOTS_CONNECT( 0 )
Called from QLISTWIDGET:CONNECT( 0 )
Called from LISTBOX:_ONDBLCLICK( 288 )
Called from LISTBOX:CREATE( 348 )
Called from WINDOW:CREATEPENDINGCHILDCONTROLS( 1336 )
Called from WINDOWGROUP:ACTIVATE( 113 )
Called from MAIN( 544 )
The error is in hmg code, from before october 15, the patch is:

Code: Select all

diff -r 49180c15d245 source/listbox.prg
--- a/source/listbox.prg        Wed Oct 27 22:48:31 2010 +0200
+++ b/source/listbox.prg        Wed Oct 27 23:42:32 2010 +0200
@@ -263,6 +263,7 @@
          RETURN ::bOnChange
       ELSEIF Pcount() == 1
          ::bOnChange := bValue
+         ::oQTObject:disconnect( "itemSelectionChanged()" )
          ::oQTObject:connect( "itemSelectionChanged()" , ::bOnChange )
       ENDIF
    ELSE
@@ -318,7 +319,6 @@
    IF ValType( ::nRow )         != 'U'; Self:Row             := ::nRow         ; ENDIF
    IF ValType( ::nCol )         != 'U'; Self:Col             := ::nCol         ; ENDIF
    IF ValType( ::nWidth )       != 'U'; Self:Width           := ::nWidth       ; ENDIF
-   IF ValType( ::bOnChange )    != 'U'; Self:OnChange        := ::bOnChange    ; ENDIF
    IF ValType( ::nHeight )      != 'U'; Self:Height          := ::nHeight      ; ENDIF
    IF ValType( ::cField )       != 'U'; Self:Field           := ::cField       ; ENDIF
    IF ValType( ::cFontName )    != 'U'; Self:FontName        := ::cFontName    ; ENDIF

The error was due to a already connected signal. The signal is double connected due to a double connect line :-)

Strange it wasn't detected before !
mrduck
Posts: 497
Joined: Fri Sep 10, 2010 5:22 pm

Re: Welcome to the Project Developers' Table

Post by mrduck »

Roberto please wait updating harbour binaries, since I found a "possible" serious bug in the libs. I'm investigating if it's a problem in my code or hbqt code.
User avatar
Roberto Lopez
HMG Founder
Posts: 4023
Joined: Wed Jul 30, 2008 6:43 pm

Re: Welcome to the Project Developers' Table

Post by Roberto Lopez »

2010-10-27 19:05:00 UTC-0300 Roberto Lopez (<mail.box.hmg@gmail.com>)
* hmgide/ide.prg
* More work on form editor. The controls can be added as in IDE previous versions.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
User avatar
Roberto Lopez
HMG Founder
Posts: 4023
Joined: Wed Jul 30, 2008 6:43 pm

Re: Welcome to the Project Developers' Table

Post by Roberto Lopez »

2010-10-27 19:10:00 UTC-0300 Roberto Lopez (<mail.box.hmg@gmail.com>)
* source/listbox.prg
* Fixed problem with OnChange event. Thanks to Francesco.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
User avatar
Roberto Lopez
HMG Founder
Posts: 4023
Joined: Wed Jul 30, 2008 6:43 pm

Re: Welcome to the Project Developers' Table

Post by Roberto Lopez »

2010-10-27 19:50:00 UTC-0300 Roberto Lopez (<mail.box.hmg@gmail.com>)
* hmgide/ide.prg
* More work on form editor. Controls buttonbar performs as in IDE previous versions.
Regards/Saludos,

Roberto


(Veritas Filia Temporis)
mrduck
Posts: 497
Joined: Fri Sep 10, 2010 5:22 pm

Re: Welcome to the Project Developers' Table

Post by mrduck »

Roberto,
I confirm there is a problem in hbqt code. Viktor is working on it
Post Reply